Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set SSLProtocol for Apache vhost #600

Merged
merged 1 commit into from
Oct 17, 2017

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Oct 16, 2017

No description provided.

@ekohl
Copy link
Member

ekohl commented Oct 16, 2017

The actual class parameter is missing. I also wonder if we should default to undef so you can set the default on apache::mod::ssl. Another downside of your setting in the tests is that it means TLSv1.3 (currrently a draft) won't be enabled if available.

@ehelms
Copy link
Member Author

ehelms commented Oct 16, 2017

I meant to add the undef and missed the class parameters. Those are updated now. As for the test example, I am open to any string for the test itself or leaving it as undef. My eventual goal will be to document how you could install and lock to TLSv1.2.

@ekohl
Copy link
Member

ekohl commented Oct 16, 2017

Never mind, I assumed that your example was in a test for equality, not a parameter.

I do expect the tests to fail in the config_passenger_spec.rb file because we have to set every parameter there. We test without the foreman class and that breaks strict variables so we override them.

@ehelms
Copy link
Member Author

ehelms commented Oct 17, 2017

Tests are passing now

@ekohl ekohl merged commit 0602750 into theforeman:master Oct 17, 2017
@ekohl
Copy link
Member

ekohl commented Oct 17, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants