always log foreman-rake output #1170
Conversation
this is useful when debugging which migrations ran and how long they took
| @@ -22,7 +22,7 @@ | |||
| command => "/usr/sbin/foreman-rake ${title}", | |||
| user => $user, | |||
| environment => sort(join_keys_to_values({ 'HOME' => $app_root } + $environment, '=')), | |||
| logoutput => 'on_failure', | |||
There was a problem hiding this comment.
This was set to on_failure (which is default, btw) since the original implementation in 88e4c16
There was a problem hiding this comment.
I was debating whether this can log any secrets, like the initial password with seeding. That particular case isn't an issue since it's not printed when provided (https://github.com/theforeman/foreman/blob/93a16bdbd7a7a819bab9d7a136dee9986b30bc08/db/seeds.d/035-admin.rb#L59-L65).
I can't think of anything else, but have you thought about that?
|
I did so, briefly. In the installer context, "this is fine", as we secure the log properly. Outside, I couldn't find anything but the seeded password which you either WANT logged (when you do not set it) or it's not printed. Migrations shouldn't print anything secret. |
this is useful when debugging which migrations ran and how long they
took