Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert per_page in foreman::foreman to string #1089

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Convert per_page in foreman::foreman to string #1089

merged 1 commit into from
Oct 28, 2022

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Oct 18, 2022

CGI.escape can only deal with strings and the function accepts per_page as an integer.

@ekohl
Convert per_page in foreman::foreman to string
549ec35 
CGI.escape can only deal with strings and the function accepts per_page
as an integer.
@ekohl ekohl added the Bug label Oct 18, 2022
@ekohl ekohl mentioned this pull request Oct 18, 2022
Closed
evgeni
evgeni approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@evgeni evgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IGNORE ALL FAILURES!

@ekohl ekohl merged commit fbbfdd2 into theforeman:master Oct 28, 2022
@ekohl ekohl deleted the deal-with-string-per-page branch October 28, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evgeni evgeni evgeni approved these changes

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ekohl @evgeni @theforeman-bot