Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add foreman plugin for netbox #1060

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Add foreman plugin for netbox #1060

merged 1 commit into from
Jun 28, 2022

Conversation

dgoetz
Copy link
Member

@dgoetz dgoetz commented Jun 3, 2022

@dgoetz dgoetz mentioned this pull request Jun 3, 2022
Merged
@dgoetz
Copy link
Member Author

dgoetz commented Jun 28, 2022

Rebased and I think Ubuntu 20.04 is simply not working and not related to the code in the PR.

ekohl
ekohl approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct - I'm not sure why Ubuntu 20.04 fails in containers in CI while it works on real VMs.

@ekohl ekohl merged commit ed4a366 into theforeman:master Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
Enhancement Needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgoetz @ekohl @theforeman-bot