-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #34089 - Add trusted proxies setting #1011
Conversation
6d81b75
to
48bc39c
Compare
I don't think the failed tests are because of this PR. Am I right? |
0b94425
to
e9f0627
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with the phrasing now. @ehelms?
I think this broke our builds, because type Stdlib::IP::Address = Variant[
Stdlib::IP::Address::V4,
Stdlib::IP::Address::V6,
] And Kafo can't parse multi-line strings properly. The resulting error message is:
|
I forgot to link back https://community.theforeman.org/t/foreman-installer-develop-package-release-1015-failed/26627/3 and #1013 but here it is. |
No description provided.