Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #34089 - Add trusted proxies setting #1011

Merged
merged 1 commit into from
Dec 23, 2021

Conversation

sbernhard
Copy link
Contributor

No description provided.

@sbernhard
Copy link
Contributor Author

I don't think the failed tests are because of this PR. Am I right?

manifests/init.pp Outdated Show resolved Hide resolved
templates/settings.yaml.erb Outdated Show resolved Hide resolved
manifests/init.pp Outdated Show resolved Hide resolved
manifests/init.pp Outdated Show resolved Hide resolved
@ekohl ekohl changed the title Fixes #34089 - Add trusted proxies Fixes #34089 - Add trusted proxies setting Dec 23, 2021
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with the phrasing now. @ehelms?

@ekohl ekohl merged commit 0a1e6fe into theforeman:master Dec 23, 2021
@evgeni
Copy link
Member

evgeni commented Jan 4, 2022

I think this broke our builds, because Stdlib::IP::Address is defined as:

  type Stdlib::IP::Address = Variant[
    Stdlib::IP::Address::V4,
    Stdlib::IP::Address::V6,
  ]

And Kafo can't parse multi-line strings properly. The resulting error message is:

D, [2022-01-04T03:15:37.585013 #6846] DEBUG -- : Using Puppet module parser KafoParsers::PuppetStringsModuleParser
F, [2022-01-04T03:15:38.845230 #6846] FATAL -- : Unable to continue because of: data type not recognized Variant[
rake aborted!

@ekohl
Copy link
Member

ekohl commented Jan 4, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants