Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #31533 - pin rake to < 13.0.2 to avoid test failures #8213

Merged
merged 1 commit into from
Dec 20, 2020

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Dec 19, 2020

Tests currently fail to run with Rake 13.0.2 with

uninitialized constant ApplicationRecord::ApipieDSL (NameError)

Pin Rake until we know how to properly fix that.

Tests currently fail to run with Rake 13.0.2 with

    uninitialized constant ApplicationRecord::ApipieDSL (NameError)

Pin Rake until we know how to properly fix that.
@evgeni evgeni changed the title test2 -- ignore uninitialized constant ApplicationRecord::ApipieDSL (NameError) Dec 19, 2020
@evgeni evgeni changed the title uninitialized constant ApplicationRecord::ApipieDSL (NameError) Refs #31533 - pin rake to < 13.0.2 to avoid test failures Dec 19, 2020
@evgeni
Copy link
Member Author

evgeni commented Dec 19, 2020

See #8207 for a PR that's failing because of this.

@evgeni
Copy link
Member Author

evgeni commented Dec 19, 2020

My best guess is that it's related to ruby/rake#357, but I am really in no mood to dig into this further.

Copy link
Member

@tbrisker tbrisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @evgeni !

@tbrisker tbrisker merged commit a6f20bc into theforeman:develop Dec 20, 2020
@ofedoren
Copy link
Member

@evgeni, @tbrisker, I've tried to reproduce this and I've noticed that even if we explicitly add require 'apipie_dsl' to ApplicationRecord, tests on 13.0.2 will fail with another error:
foreman/lib/foreman/http_proxy/excon_connection_extension.rb:20:in '<top (required)>': uninitialized constant Excon (NameError)

I thought that this is another issue with apipie-dsl, but fortunatelly it isn't.

@evgeni
Copy link
Member Author

evgeni commented Dec 20, 2020

Did you try the explicitly calling top-scope ::ApipieDSL and ::Excon? That would've my next try

Edit: oh wait, in the excon case it doesn't even think it's part of something else. 🤷‍♀️

@evgeni evgeni deleted the rake-test-2 branch December 20, 2020 18:39
@ofedoren
Copy link
Member

@evgeni, before explicit require 'apipie-dsl' I've tried to call ::ApipieDSL in ApplicationRecord, but it didin't work :(

@evgeni
Copy link
Member Author

evgeni commented Dec 20, 2020

Seems there is some progress upstream: ruby/rake#368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants