Incorperate Mjolnir's new Policy List Manager #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Gnuxie
commented
Jan 19, 2023
Gnuxie
commented
- This should hopefully fix some startup woes matrix-org/mjolnir#462
- PolicyListManager: Let's not forget to remove the room also from the set of rooms we failed to resolve matrix-org/mjolnir#463
Gnuxie
commented
Jan 19, 2023
Comment on lines
406
to
418
| // We filter out all policy rooms so that we only protect ones that are | ||
| // explicitly protected, so that we don't try to protect lists that we are just watching. | ||
| const filterOutManagementAndPolicyRooms = (roomId: string) => { | ||
| const policyListIds = this.policyLists.map(list => list.roomId); | ||
| const policyListIds = this.policyListManager.lists.map(list => list.roomId); | ||
| return roomId !== this.managementRoomId && !policyListIds.includes(roomId); | ||
| }; |
There was a problem hiding this comment.
It is a smell that this filter has been ignored and not included as part of the PolicyListManager.
There was a problem hiding this comment.
Ok, that's because it's to do with protected rooms, not the policy list manager... maybe it could be moved there though?
| @@ -70,7 +71,7 @@ describe("UnbanBanCommand", () => { | |||
|
|
|||
| it("should be able to detect servers with ban reasons", async () => { | |||
| const mjolnir = createTestMjolnir(); | |||
| (<any>mjolnir).lists = [{listShortcode: "test"}]; | |||
| (<any>mjolnir).policyListManager.lists = [{listShortcode: "test"}]; | |||
There was a problem hiding this comment.
While I think there has been a precedent for exposing these utilities externally from Mjolnir, I think we should at least try keeping them internal to Mjolnir and delegating.
Gnuxie
commented
Jan 25, 2023
Gnuxie
commented
Jan 26, 2023
Gnuxie
force-pushed
the
gnuxie/policy-list-manager
branch
2 times, most recently
from
96ee740
to
cb6af7e
Compare
Splitting PolicyListManager from Mjolnir, making it more resilient to startup errors
…set of rooms we failed to resolve (#463)
Gnuxie
force-pushed
the
gnuxie/policy-list-manager
branch
from
cb6af7e
to
9797e32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.