Read secrets from command line provided paths, if specified #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…e check for undefined now
… have weird behavior with false-y named files in CWD
for more information, see https://pre-commit.ci
Gnuxie
reviewed
Feb 7, 2024
Gnuxie
reviewed
Feb 7, 2024
for more information, see https://pre-commit.ci
Gnuxie
reviewed
Feb 7, 2024
Comment on lines
+341
to
+344
| //check if the next index is not an option | ||
| if (args[optionIndex + 1] && !args[optionIndex + 1].startsWith("--")){ | ||
| return args[optionIndex + 1]; | ||
| } |
|
Code has been tested for a few cases (passing no arg, passing invalid path, not passing arg at all, and passing a valid file), appears to work as expected |
Gnuxie
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.