store: add chunk pooling #7771
Merged
store: add chunk pooling #7771
+151
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiedriusS
force-pushed
the
chk_pooling
branch
4 times, most recently
from
04aa016
to
ac23997
Compare
Pool byte slices inside of aggrchunks. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
GiedriusS
force-pushed
the
chk_pooling
branch
from
ac23997
to
9a2dca9
Compare
Comment on lines
+141
to
+145
| var returnChunksSlicePool = sync.Pool{ | ||
| New: func() interface{} { | ||
| r := make([]*storepb.AggrChunk, 0) | ||
| return &r | ||
| }, |
There was a problem hiding this comment.
Maybe we can use the pool.BucketedPool and avoid casts down the road and the need to add a new explicit mutex?
There was a problem hiding this comment.
What min/max sizes and factor would you suggest? It's hard to make a judgment here :/
There was a problem hiding this comment.
Yeah, you got a point as well. Kinda hard to estimate average chunks touched by queries. Let's leave it like this then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pool byte slices inside of aggrchunks.