fix creds

Signed-off-by: alanprot <alanprot@gmail.com>
thanos-io · Jun 10, 2024 · 0419db6 · 0419db6
1 parent a1e9a67
commit 0419db6
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pkg/clientconfig/http.go b/pkg/clientconfig/http.go
@@ -176,9 +176,9 @@ func NewRoundTripperFromConfig(cfg config_util.HTTPClientConfig, transportConfig
 
 		if cfg.BasicAuth != nil {
 			// TODO(yeya24): expose UsernameFile as a config.
-			if len(cfg.BasicAuth.PasswordFile) >= 0 {
+			if len(cfg.BasicAuth.PasswordFile) > 0 {
 				rt = config_util.NewBasicAuthRoundTripper(config_util.NewInlineSecret(cfg.BasicAuth.Username), config_util.NewInlineSecret(cfg.BasicAuth.PasswordFile), rt)
-			} else if len(cfg.BasicAuth.Password) >= 0 {
+			} else if len(cfg.BasicAuth.Password) > 0 {
 				rt = config_util.NewBasicAuthRoundTripper(config_util.NewInlineSecret(cfg.BasicAuth.Username), config_util.NewInlineSecret(string(cfg.BasicAuth.Password)), rt)
 			}
 		}