Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to minimize to tray #394

Merged
merged 3 commits into from
Oct 4, 2020

Conversation

michaelknowles
Copy link

Related issue

#350

Context / Background

The issue submitter wants to have the option to either minimize to the taskbar, or minimize to the tray.

What change is being introduced by this PR?

I mirrored the approach used for the close-to-tray feature. An option was added to the preferences with similar wording in the same location. It defaults to true (minimize-to-tray) as this keeps the behavior consistent with before.
image

How will this be tested?

Tested manually. I didn't see any tests for the similar close-to-tray feature to mirror.

@codecov
Copy link

codecov bot commented Oct 2, 2020

Codecov Report

Merging #394 into main will decrease coverage by 0.02%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #394      +/-   ##
==========================================
- Coverage   56.57%   56.54%   -0.03%     
==========================================
  Files          25       25              
  Lines        2379     2382       +3     
  Branches      402      404       +2     
==========================================
+ Hits         1346     1347       +1     
- Misses        913      914       +1     
- Partials      120      121       +1     
Impacted Files Coverage Δ
js/main-window.js 0.00% <0.00%> (ø)
js/user-preferences.js 92.52% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 416a04d...00695d0. Read the comment docs.

Copy link
Collaborator

@araujoarthur0 araujoarthur0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like adding more choice to the user.

js/main-window.js Show resolved Hide resolved
js/main-window.js Outdated Show resolved Hide resolved
@thamara thamara merged commit 819bbe8 into thamara:main Oct 4, 2020
thamara added a commit that referenced this pull request Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants