Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix preference window width #382

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Fix preference window width #382

merged 1 commit into from
Oct 2, 2020

Conversation

ibamibrhm
Copy link
Contributor

Fixes #362

Screen Shot 2020-10-01 at 21 21 07

@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #382 into main will increase coverage by 1.47%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #382      +/-   ##
==========================================
+ Coverage   57.86%   59.34%   +1.47%     
==========================================
  Files          23       23              
  Lines        2046     2873     +827     
  Branches      344      575     +231     
==========================================
+ Hits         1184     1705     +521     
- Misses        762     1005     +243     
- Partials      100      163      +63     
Impacted Files Coverage Δ
js/menus.js 0.00% <0.00%> (ø)
js/window-aux.js 92.59% <0.00%> (-7.41%) ⬇️
js/import-export.js 97.98% <0.00%> (-0.13%) ⬇️
main.js 0.00% <0.00%> (ø)
js/themes.js 100.00% <0.00%> (ø)
js/windows.js 0.00% <0.00%> (ø)
js/date-aux.js 100.00% <0.00%> (ø)
js/time-math.js 100.00% <0.00%> (ø)
js/app-config.js 0.00% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a41e44d...1f9c35d. Read the comment docs.

@araujoarthur0
Copy link
Collaborator

Thanks @ibamibrhm , can you add an entry to the changelog.md file?

@thamara
Copy link
Owner

thamara commented Oct 2, 2020

I needed to merge this as another dependency on this has show up. But I included your name and the fix on the changelog.
Congratulations on your first PR merged into TTL!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preferences window is too small for its content
3 participants