Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving performance of all time balance calculation #336

Merged
merged 4 commits into from
Aug 7, 2020

Conversation

araujoarthur0
Copy link
Collaborator

Related issue

Closes #334

Context / Background

All time balance calculation introduced a big performance degradation on TTL.

What change is being introduced by this PR?

  • Fixing function name (extra L)
  • Fixing targetDate on Calendar
  • Avoiding store.get calls on all time balance calculation to improve performance.

How will this be tested?

npm run test

Compare this with the issues's image:
delay

@codecov
Copy link

codecov bot commented Aug 1, 2020

Codecov Report

Merging #336 into main will increase coverage by 0.59%.
The diff coverage is 96.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #336      +/-   ##
==========================================
+ Coverage   57.93%   58.52%   +0.59%     
==========================================
  Files          14       14              
  Lines        1431     1454      +23     
  Branches      241      244       +3     
==========================================
+ Hits          829      851      +22     
- Misses        527      528       +1     
  Partials       75       75              
Impacted Files Coverage Δ
js/classes/Calendar.js 79.47% <92.30%> (+0.11%) ⬆️
js/time-balance.js 98.50% <97.29%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 057e81b...033da66. Read the comment docs.

@thamara
Copy link
Owner

thamara commented Aug 7, 2020

@araujoarthur0 Can you please add an entry on changelog? After this, I think you can merge it on the branch. :)

@araujoarthur0 araujoarthur0 merged commit 297217a into thamara:main Aug 7, 2020
@araujoarthur0 araujoarthur0 deleted the overall-balance-fix branch August 7, 2020 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overall balance performance issue
2 participants