Skip to content

Commit

Permalink
tests: re-enable dump-ice-to-disk for Windows
Browse files Browse the repository at this point in the history
This test was previously flakey on `i686-mingw`, but since some
modifications I could no longer make it fail on `i686-mingw`.

See <rust-lang#128958> for multiple try
job runs.
  • Loading branch information
jieyouxu committed Aug 15, 2024
1 parent 13a5289 commit 35785ef
Showing 1 changed file with 8 additions and 5 deletions.
13 changes: 8 additions & 5 deletions tests/run-make/dump-ice-to-disk/rmake.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,14 @@
//! that `RUSTC_ICE_PATH` takes precedence and no ICE dump is emitted under `METRICS_PATH`.
//!
//! See <https://github.com/rust-lang/rust/pull/108714>.

//@ ignore-windows
// FIXME(#128911): @jieyouxu: This test is sometimes for whatever forsaken reason flakey in
// `i686-mingw`, and I cannot reproduce it locally. The error messages upon assertion failure in
// this test is intentionally extremely verbose to aid debugging that issue.
//!
//! # Test history
//!
//! - The previous rmake.rs iteration of this test was flakey for unknown reason on `i686-mingw`
//! *specifically*, so assertion failures in this test was made extremely verbose to help
//! diagnose why the ICE messages was different *specifically* on `i686-mingw`.
//! - An attempt is made to re-enable this test on `i686-mingw` (by removing `ignore-windows`). If
//! this test is still flakey, please restore the `ignore-windows` directive.

use std::cell::OnceCell;
use std::path::{Path, PathBuf};
Expand Down

0 comments on commit 35785ef

Please sign in to comment.