Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate ccs v3 to @adobe/css-tools v4 #470

Merged
merged 2 commits into from
Aug 4, 2022
Merged

Migrate ccs v3 to @adobe/css-tools v4 #470

merged 2 commits into from
Aug 4, 2022

Conversation

holblin
Copy link
Contributor

@holblin holblin commented Jul 15, 2022

What:

Migrate the dependency css to @adobe/css to reduce maintained dependencies.

Closes #435

Why:

CSS package is not maintained anymore and has some sub-dependencies which are deprecated.

How:

Change the import

Checklist:

  • Documentation N/A
  • Tests N/A
  • Updated Type Definitions N/A
  • Ready to be merged

@holblin
Copy link
Contributor Author

holblin commented Jul 15, 2022

Note: The version 4 of @adobe/css-tools is very recent. I used import {parse} from '@adobe/css-tools/dist/cjs/cssTools' to make sure it load the cjs build and not the umd build. If someone knows why jest-dom try to load the umd build instead of the cjs and have a solution, feel free to share :-)

@MichaelDeBoey MichaelDeBoey requested a review from a team July 17, 2022 14:21
@codecov
Copy link

codecov bot commented Jul 17, 2022

Codecov Report

Merging #470 (2594583) into main (af18453) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #470   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          630       630           
  Branches       234       236    +2     
=========================================
  Hits           630       630           
Impacted Files Coverage Δ
src/utils.js 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm not a current maintainer. If nobody merges in the next week or so though I'll go ahead and merge

@holblin
Copy link
Contributor Author

holblin commented Aug 4, 2022

@kentcdodds I updated the import to solve the CJS import path that I was using :-)
Could you merge it when you get some time? 😇 Thanks!

@MichaelDeBoey MichaelDeBoey requested review from a team and kentcdodds August 4, 2022 11:30
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@kentcdodds kentcdodds merged commit 948d90f into testing-library:main Aug 4, 2022
@github-actions
Copy link

github-actions bot commented Aug 4, 2022

🎉 This PR is included in version 5.16.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@holblin holblin deleted the migrate-css branch August 4, 2022 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated source-map-resolve@0.6.0
4 participants