Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the globalThis of UMD package to allow nodejs to use it. #33

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Change the globalThis of UMD package to allow nodejs to use it. #33

merged 1 commit into from
Aug 4, 2022

Conversation

holblin
Copy link

@holblin holblin commented Aug 4, 2022 •
edited
Loading

Description

Tentative to make the UMD build also works in Nodejs environment.

Related Issue

testing-library/jest-dom#470

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@holblin holblin merged commit 80d553b into main Aug 4, 2022
@holblin holblin deleted the umd-self branch August 4, 2022 03:16
@usr-ein
Copy link

usr-ein commented Aug 4, 2022

I was about to make the same changes because I ran into the same error! Thanks for merging this 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@holblin @usr-ein