Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The visibility check on Microsoft Edge is always true #59

Closed
KDLees opened this issue Jan 13, 2020 · 1 comment · Fixed by #60
Closed

The visibility check on Microsoft Edge is always true #59

KDLees opened this issue Jan 13, 2020 · 1 comment · Fixed by #60
Assignees
@terwanerik
Labels
bug

Comments

@KDLees
Copy link

KDLees commented Jan 13, 2020

The _checkVisibility function uses the x and y values from the 'rect' object returned by getBoundingClientRect().

The getBoundingClientRect() function on Edge does not return these values so they are undefined.

Setting rect.x to rect.left and rect.y to rect.top fixed my issue on Edge.
@terwanerik terwanerik self-assigned this Jan 16, 2020
@terwanerik terwanerik added the bug label Jan 16, 2020
terwanerik pushed a commit that referenced this issue Jan 16, 2020
Made sure the .top and .left of the ClientBoundingRect are used i…
28ae7a2 
…nstead of `x` and `y`. Fixes #59 thanks to @KDLees
@terwanerik terwanerik mentioned this issue Jan 16, 2020
Merged
terwanerik added a commit that referenced this issue Jan 16, 2020
@terwanerik
Microsoft edge fix 59 (#60)
18bca38 
* Made sure the `.top` and `.left` of the ClientBoundingRect are used instead of `x` and `y`. Fixes #59 thanks to @KDLees

* Updated dependencies and version to 1.0.4
Added updated build
@terwanerik
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terwanerik terwanerik

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Microsoft edge fix 59 terwanerik/ScrollTrigger
2 participants
@terwanerik @KDLees