Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] RewardWeightUpdateProposal CLI parse error #456

Merged
merged 1 commit into from
Mar 3, 2021
Merged

[Bugfix] RewardWeightUpdateProposal CLI parse error #456

merged 1 commit into from
Mar 3, 2021

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Mar 3, 2021 •
edited
Loading

Summary of changes

fix #455

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo self-assigned this Mar 3, 2021
@yun-yeo yun-yeo requested a review from hanjukim March 3, 2021 04:23
@yun-yeo yun-yeo added bug Something isn't working client rest / cli code improvements labels Mar 3, 2021
@hanjukim hanjukim changed the title fix parse error Fix parse error Mar 3, 2021
@hanjukim hanjukim changed the title Fix parse error [Bugfix] RewardWeightUpdateProposal parse error Mar 3, 2021
@hanjukim hanjukim changed the title [Bugfix] RewardWeightUpdateProposal parse error [Bugfix] RewardWeightUpdateProposal CLI parse error Mar 3, 2021
@yun-yeo yun-yeo merged commit eb93425 into master Mar 3, 2021
@yun-yeo yun-yeo deleted the bugfix/treasury-reward-weight-update-cli branch March 3, 2021 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanjukim hanjukim hanjukim approved these changes

Assignees

@yun-yeo yun-yeo

Labels
bug Something isn't working client rest / cli code improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] RewardWeightUpdate proposal client parse key
2 participants
@yun-yeo @hanjukim