Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] RewardWeightUpdate proposal client parse key #455

Closed
yun-yeo opened this issue Mar 3, 2021 · 0 comments · Fixed by #456
Closed

[BUG] RewardWeightUpdate proposal client parse key #455

yun-yeo opened this issue Mar 3, 2021 · 0 comments · Fixed by #456
Assignees
Labels
bug Something isn't working client rest / cli code improvements

Comments

@yun-yeo
Copy link
Contributor

yun-yeo commented Mar 3, 2021

Describe the bug

When we create proposal with cmd, we define the proposal.json file format like below

	RewardWeightUpdateProposalJSON struct {
		Title        string    `json:"title" yaml:"title"`
		Description  string    `json:"description" yaml:"description"`
		RewardWeight sdk.Dec   `json:"tax_rate" yaml:"tax_rate"`
		Deposit      sdk.Coins `json:"deposit" yaml:"deposit"`
	}

But, it is mapping RewardWeight to tax_rate json key.

To Reproduce
Try to create RewardWeightUpdateProposal via cmd

Context & versions
v0.4.x

(if applicable) suggested solution
map RewardWeight to reward_weight json key.

@yun-yeo yun-yeo added the bug Something isn't working label Mar 3, 2021
@yun-yeo yun-yeo changed the title [BUG] RewardWeightUpdate proposal cmd side wrong file object [BUG] RewardWeightUpdate proposal client parse key Mar 3, 2021
@yun-yeo yun-yeo added the client rest / cli code improvements label Mar 3, 2021
@yun-yeo yun-yeo self-assigned this Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client rest / cli code improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant