Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Float bubble fixes #38

Merged
merged 3 commits into from
Sep 3, 2021

Conversation

dkramer95
Copy link
Member

  • Fixed: Use dp instead of px so bubble size should now be consistent across devices.
  • Fixed: Some change in 90f908d caused the outline to be cut off when in bubble mode but now displays properly.
    • Removed round_button.xml drawable as no longer needed

@dkramer95
Copy link
Member Author

@agnostic-apollo Apart from the cutoff outline (which I have fixed), the latest changes on master looked good.

@agnostic-apollo
Copy link
Member

I have removed unneeded copying of ViewUtils. The termux-shared library is already a dependency so can use it directly.

As for bubble size, it has now increased in size on my LG G5. 60dp is better for me. Did you increase it deliberately or is it the same size with the new change on your phone(s)?

Thanks for checking the rest.

@dkramer95
Copy link
Member Author

dkramer95 commented Sep 3, 2021

The size was same for me. This is what it looks like on my device with some other regular icons for scale.

(It probably increased in size now that it is using dp. Same thing happened when I tested on S7.. That's when I noticed issue because S7 initially was displaying smaller than my other devices... This should probably be a customizable option as well as users may want bubble smaller or larger)

@agnostic-apollo
Copy link
Member

Yeah, see its bigger than your normal icons. Point of floating button is to be small so that its not intrusive to other apps. Try 60dp yourself and compare with an app that has a chat head like messenger. Android's FloatingActionButton.SIZE_NORMAL is set to 56dp actually and we should probably use that. Customizable option can be added in future.

I forgot to mention the likely cause for the border issue, it may have something to do with color.properties support that was setting the TerminalView background color but is fixed now, so not an issue.

@dkramer95
Copy link
Member Author

dkramer95 commented Sep 3, 2021

Android's FloatingActionButton.SIZE_NORMAL is set to 56dp actually and we should probably use that.

I have changed the default size to 56dp to follow this standard.

Customizable option can be added in future.

Ya, IMO I think bubble looks better slightly larger. But more incentive for me to work on this, as I'm sure other users will appreciate customizations :)

I forgot to mention the likely cause for the border issue, it may have something to do with color.properties support that was setting the TerminalView background color but is fixed now, so not an issue.

It worked out because I was able to get outline to draw a little nicer than before.

@agnostic-apollo
Copy link
Member

I have changed the default size to 56dp to follow this standard.

Thanks. This perfectly matches flynx browser bubble as well.

think bubble looks better slightly larger. But more incentive for me to work on this,

Yeah, you right, you can fix your own problems here ;) Make sure to have min/max range

It worked out because I was able to get outline to draw a little nicer than before.

Yeah, I didn't even notice it before.

@agnostic-apollo agnostic-apollo merged commit 648dbff into termux:master Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants