-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor Float bubble fixes #38
Conversation
@agnostic-apollo Apart from the cutoff outline (which I have fixed), the latest changes on |
21310ef
to
8863995
Compare
I have removed unneeded copying of As for bubble size, it has now increased in size on my LG G5. Thanks for checking the rest. |
The size was same for me. This is what it looks like on my device with some other regular icons for scale. (It probably increased in size now that it is using |
Yeah, see its bigger than your normal icons. Point of floating button is to be small so that its not intrusive to other apps. Try I forgot to mention the likely cause for the border issue, it may have something to do with |
I have changed the default size to
Ya, IMO I think bubble looks better slightly larger. But more incentive for me to work on this, as I'm sure other users will appreciate customizations :)
It worked out because I was able to get outline to draw a little nicer than before. |
Thanks. This perfectly matches flynx browser bubble as well.
Yeah, you right, you can fix your own problems here ;) Make sure to have min/max range
Yeah, I didn't even notice it before. |
dp
instead ofpx
so bubble size should now be consistent across devices.round_button.xml
drawable as no longer needed