forked from logstash-plugins/logstash-input-http
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DropWizard metrics #76
Open
51-code
wants to merge
11
commits into
teragrep:main
Choose a base branch
from
51-code:metrics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
p000010u
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
kortemik
reviewed
Sep 19, 2024
kortemik
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup can be found in Metrics.java.
Includes new config parameter:
prometheus.port
with a default of 1234. This is the port for the Jetty server that provides the metrics.Metrics include:
I tried my best to not fill the existing objects with the metrics, so I made decorators where applicable. The metrics are somewhat scattered, as objects have different responsibilities:
resends
,retriedConnects
,records
andbytes
. Would have liked to make this a decorator as well, but resends and retriedConnects are inner logic of the object when a message has been sent so this would need refactoring to do the metrics in a decorator.connects
andconnectLatency
. RelpConnection is the only object that actually deals with the connections so these metrics were placed in its decorator.sendLatency
because RelpConversion is the object that has a hold on the whole processing of the message.