Fix stacking of notification dot #6875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An upcoming change in Angular Material (angular/components#29291) changes the `z-index` of icons which ended up putting it behind the notification dot. This change adds an explicit `z-index` to the dot to ensure that it's on top of the icon.
hoonji
approved these changes
Jul 3, 2024
groszewn
pushed a commit
to groszewn/tensorboard
that referenced
this pull request
Aug 13, 2024
An upcoming change in Angular Material (angular/components#29291) changes the `z-index` of icons which ended up putting it behind the notification dot. This change adds an explicit `z-index` to the dot to ensure that it's on top of the icon.
groszewn
pushed a commit
that referenced
this pull request
Aug 13, 2024
An upcoming change in Angular Material (angular/components#29291) changes the `z-index` of icons which ended up putting it behind the notification dot. This change adds an explicit `z-index` to the dot to ensure that it's on top of the icon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An upcoming change in Angular Material (angular/components#29291) changes the
z-indexof icons which ended up putting it behind the notification dot.This change adds an explicit
z-indexto the dot to ensure that it's on top of the icon.