Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4047 Fail to compile with Protobuf2 #4158

Closed

Conversation

mastash3ff
Copy link

See issue #4047 for more details on the problems encountered and fix.

…ng .proto files. although statement compiles with protobuf3, runtime of the program will fail since there are dependencies on protobuf2.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@mastash3ff
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels May 3, 2018
@pkulzc
Copy link
Contributor

pkulzc commented May 3, 2018

This "reserved" is required so future user would not accidentally reuse a deprecated field number.
Try using protobuf3 as described in the updated installation doc.

@pkulzc
Copy link
Contributor

pkulzc commented May 3, 2018

I'm closing this PR, but feel free to reopen it if you have any questions, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants