Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new import paths to mnist_tpu.py #4133

Merged
merged 5 commits into from
Apr 30, 2018
Merged

Conversation

frankchn
Copy link
Contributor

This adds new import paths to mnist_tpu.py so individuals can check out the git repository and run python mnist_tpu.py without finagling with python import search paths.

This adds new import paths to mnist_tpu.py so individuals can check out the git repository and run `python mnist_tpu.py` without finagling with python import search paths.
@frankchn frankchn requested review from karmel and a team as code owners April 30, 2018 18:09
@karmel karmel requested a review from robieta April 30, 2018 18:10
@robieta
Copy link
Contributor

robieta commented Apr 30, 2018

Why is the parent path needed? Shouldn't it only be grandparent?

@frankchn
Copy link
Contributor Author

@robieta Good point, removed.

Copy link
Contributor

@robieta robieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frankchn frankchn merged commit cb1567e into master Apr 30, 2018
karmel pushed a commit that referenced this pull request May 1, 2018
* Add new import paths to mnist_tpu.py

This adds new import paths to mnist_tpu.py so individuals can check out the git repository and run `python mnist_tpu.py` without finagling with python import search paths.

* Fix lint errors

* Add disable= to pylint instructions

* Remove parent path

* Update comments
xueeinstein added a commit to xueeinstein/models that referenced this pull request May 2, 2018
* 'master' of https://github.com/tensorflow/models: (404 commits)
  official/mnist: Updates with the release of TensorFlow 1.8.
  Internal changes to slim and object detection (tensorflow#4100)
  catch cpuinfo ImportError (tensorflow#4138)
  [samples/core/get_starter/eager]: Update with API simplifications in 1.8
  Add vincentvanhoucke as owner for research/marco
  Add marco subdirectory to README.md
  Create request.json
  Create jpeg2json.py
  Fix width / height.
  Create README.md
  Add new import paths to mnist_tpu.py (tensorflow#4133)
  fix model call (tensorflow#4132)
  Remove useless fields in resnet_model (tensorflow#4110)
  official/mnist: Add input_shape parameter to initial layer (tensorflow#4104) (tensorflow#4118)
  Increase minimum TF version for DEFINE_enum and rename variable mappings for change to RNN variable names. (tensorflow#4123)
  fix import errors
  Minor update the resnet runloop. (tensorflow#4113)
  Two new plot-generating scripts and changes in support of the ICLR poster. (tensorflow#4092)
  Add export savedmodel to wide_deep (tensorflow#4041)
  Fix 2 typos
  ...
omegafragger pushed a commit to omegafragger/models that referenced this pull request May 15, 2018
* Add new import paths to mnist_tpu.py

This adds new import paths to mnist_tpu.py so individuals can check out the git repository and run `python mnist_tpu.py` without finagling with python import search paths.

* Fix lint errors

* Add disable= to pylint instructions

* Remove parent path

* Update comments
@tfboyd tfboyd deleted the frankchn-fix-tpu-import branch February 7, 2019 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants