Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move openexr to runtime dependency #691

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jonas-eschle
Copy link

OpenEXR is meant to be an optional dependency as raised in #421.

Moved it away from the requirements.txt (where it probably never should have been) and added a runtime check for the import and version.

Alternatively, having extras like [dev] or [openexr] in the requirements could be a step forward, in general, to make this better manageable.

@jonas-eschle
Copy link
Author

@nkovela1 can we maybe get this merged? If it needs to be, I can also become a maintainer of the repo to help with PRs

This is actively preventing people from installing the package, unfortunately

@nkovela1
Copy link
Contributor

I will defer to @G4G on this, as he is the owner of the TF graphics repo.

@mering
Copy link

mering commented Aug 13, 2024

@nkovela1 @G4G any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants