Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Normalize extensions for leading dot & update doctests to new resources #92

Merged
merged 4 commits into from
Mar 31, 2022

Conversation

oesteban
Copy link
Member

Resolves: #86.

@oesteban oesteban force-pushed the fix/issue-86 branch 3 times, most recently from ba5b4e4 to e75a4ca Compare March 31, 2022 09:43
@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #92 (c33b9f7) into master (af8c013) will decrease coverage by 0.07%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
- Coverage   89.77%   89.69%   -0.08%     
==========================================
  Files           5        5              
  Lines         225      233       +8     
==========================================
+ Hits          202      209       +7     
- Misses         23       24       +1     
Flag Coverage Δ
api 89.69% <87.50%> (-0.08%) ⬇️
config 55.79% <12.50%> (-1.54%) ⬇️
datalad 80.68% <87.50%> (+0.24%) ⬆️
dls3 59.65% <87.50%> (+0.98%) ⬆️
s3 62.66% <87.50%> (+0.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
templateflow/api.py 80.20% <87.50%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6cde5a...c33b9f7. Read the comment docs.

@oesteban oesteban merged commit 6d31a32 into master Mar 31, 2022
@oesteban oesteban deleted the fix/issue-86 branch March 31, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension argument of get() does not match if the initial dot is missing
1 participant