MAINT: Switch to a setup.cfg-style of installation
#24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
reviewed
Jul 13, 2019
| TF_LAYOUT = Layout( | ||
| str(TF_HOME), validate=False, config='templateflow', | ||
| ignore=['.git', '.datalad', '.gitannex', '.gitattributes', 'scripts']) | ||
| except ImportError: |
There was a problem hiding this comment.
What condition should this happen under? You've got pybids ~= 0.9.2 in your install_requires.
There was a problem hiding this comment.
For some reason pybids is not available when running the update script during install - could dig more into this, but I'm not sure it's worthy.
There was a problem hiding this comment.
Ah, you could add pybids to setup_requires and pyproject.toml. Very heavy lifts, though...
| from .bids import Layout | ||
| TF_LAYOUT = Layout( | ||
| str(TF_HOME), validate=False, config='templateflow', | ||
| ignore=['.git', '.datalad', '.gitannex', '.gitattributes', 'scripts']) |
There was a problem hiding this comment.
These may be automatically ignored these days... I might flag them for review in a future PR, though not worth the trouble for this PR, IMO.
Co-Authored-By: Chris Markiewicz <markiewicz@stanford.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.