-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: Python 3.12 support, drop Python 3.7 and pkg_resources #109
Conversation
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
@mgxd Could I trouble you for a review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and +1 for a much needed new release!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to do this - but this feels useful / general enough to warrant standalone packaging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. I'm starting to think that. On the other hand, I'm not sure how much I love the idea of an extra dependency. I'm starting to think about doing something like setuptools_scm and making a build-time tool that will vendor itself to a desired location.
From niworkflows tests, it looks like setuptools has finally killed off pkg_resources. Need to get a templateflow release without it.