Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Use Path.as_posix() and f-strinigs to build correct URLs on Windows #107

Merged
merged 2 commits into from
Oct 12, 2023
Merged

FIX: Use Path.as_posix() and f-strinigs to build correct URLs on Windows #107

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb88d1d
build correct url from windows paths
mfschmidt Apr 15, 2023
5a235f9
RF: Use as_posix() and f-strings to construct URL
effigies Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions templateflow/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,8 +291,8 @@ def _s3_get(filepath):
from tqdm import tqdm
import requests

path = str(filepath.relative_to(TF_LAYOUT.root))
url = "%s/%s" % (TF_S3_ROOT, path)
path = filepath.relative_to(TF_LAYOUT.root).as_posix()
url = f"{TF_S3_ROOT}/{path}"

print("Downloading %s" % url, file=stderr)
# Streaming, so we can iterate over the response.
Expand Down