Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datalad-free fallback #5

Closed
effigies opened this issue Feb 22, 2019 · 2 comments
Closed

Datalad-free fallback #5

effigies opened this issue Feb 22, 2019 · 2 comments

Comments

@effigies
Copy link
Contributor

If datalad.api cannot be imported, perhaps stubs can be used to simply construct the path and run os.path.exists() to check whether the link can be dereferenced.

Related: neurostars #3619, neurostars #3639
@yarikoptic
Copy link
Contributor

or just issue a warning and assume that all data is there? if it is not there and needed, it would fail anyways

@effigies
Copy link
Contributor Author

But the problem is templateflow.get (or whatever) wraps datalad.get (or whatever), which is how the path is actually resolved.

oesteban added a commit that referenced this issue Mar 1, 2019
@oesteban
[ENH] Use a BIDSLayout to index TemplateFlow
30a5cf4 
Uses pybids to access the data (fixes #4).

Additionally, resorts to datalad iff there are missing
files (rel. #5). I will not close that one because this is not
really a datalad-free fallback.
@oesteban oesteban mentioned this issue Mar 1, 2019
Merged
@oesteban oesteban mentioned this issue Mar 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yarikoptic @effigies