FIX metadata expression evaluation in doc #1641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgalan
commented
Aug 8, 2024
| @@ -353,45 +354,6 @@ e.g.: | |||
| } | |||
| ``` | |||
|
|
|||
| Metadata could also has `expression` like attributes in order to expand it: | |||
There was a problem hiding this comment.
Moved to new section "Metadata transformation" "Expression support in metadata".
fgalan
commented
Aug 8, 2024
Comment on lines
-616
to
-618
| Moreover, if attribute metadata has an expression metadata attribute value in jexl context it is updated after that | ||
| expression is evaluated. Note that there is no order into metadata structure and there is no warranty about which | ||
| metadata attribute expression will be evaluated first. |
There was a problem hiding this comment.
Moreover, if attribute metadata has an expression metadata attribute value in jexl context it is updated after that
expression is evaluated
I think this is redundant with the contents of "Measurement tranformation" section, so it is removed.
Note that there is no order into metadata structure and there is no warranty about which
metadata attribute expression will be evaluated first.
This is about evaluation ordering, so moved to "Measurement transformation order" "Expression support in metadata" section.
fgalan
commented
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe related (not sure) #1634