Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap nop final step with entrypoint #748

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Wrap nop final step with entrypoint #748

merged 1 commit into from
Apr 10, 2019

Commits on Apr 10, 2019

  1. Wrap nop final step with entrypoint 

    `nop` image/step used to be executed *only* when all the previous step
were done sucessfully. As we are not using init containers anymore,
this is not true, `nop` will always be executed even in case of
previous failure (after the others though). This happens because we
don't use the `entrypoint` wrapper for this final step.

This fixes it by wrapping `nop` with entrypoint — just like other
steps. That way, it will only print `build successful` in case of
actual successful run 💃

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
    @vdemeester
    vdemeester committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    1ea0766 View commit details
    Browse the repository at this point in the history