Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release on latest tekton #1421

Merged
merged 2 commits into from
Oct 14, 2019

Conversation

afrittoli
Copy link
Member

Changes

Change the release pipeline so that it runs on the latest version
of Tekton. We can now run manual releases from the dogfooding
cluster so there's no reason to keep compatibility to old version
of Tekton.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Describe any user facing changes here, or delete this block.

Examples of user facing changes:
- API changes
- Bug fixes
- Any changes in behavior

When running YAML E2E tests, use kubectl create instead of apply,
so that example can use generateName, which is a best practice
for run objects (TaskRun/PipelineRun).

Using "create" also exposed name conflicts for several resources
all named the same. Luckily the content of those secret was the
same, so we had no race condition in the past, but it's best
to avoid side effects between tests as much as possible and
keep resource names uniques across examples.

With this change we start running taskrun tests again, and it
turns out the gitlab test is broken because of a broken gitlab URL.
Introduce a subfolder for examples that are valid but that we
don't want to run in CI because they need some access to a
resource which is not available.

The Gitlab test has been removed before this was merged, but
keeping the no-ci folder anyways as it may be useful for examples
that we have no easy way to run in CI.

Fixes tektoncd#1397
@tekton-robot tekton-robot requested review from imjasonh and a user October 14, 2019 10:42
@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Oct 14, 2019
@afrittoli
Copy link
Member Author

/hold

@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 14, 2019
@afrittoli
Copy link
Member Author

I'm still testing this in the dogfooding cluster.

Change the release pipeline so that it runs on the latest version
of Tekton. We can now run manual releases from the `dogfooding`
cluster so there's no reason to keep compatibility to old version
of Tekton.
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2019
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2019
@afrittoli afrittoli added this to the Pipelines 0.8 🐱 milestone Oct 14, 2019
@afrittoli
Copy link
Member Author

I tested this using the staging bucket and the staging namespace on gcr.io, and it worked fine. Here are the logs for the pipelinerun pipeline-release-run-cjxzk, which was started with:

export VERSION_TAG=v0.8.0alpha
export IMAGE_REGISTRY=gcr.io/tekton-releases/staging
tkn pipeline start --param=versionTag=${VERSION_TAG} --param=imageRegistry=${IMAGE_REGISTRY} --serviceaccount=release-right-meow         --resource=source-repo=tekton-pipelines-git         --resource=bucket=tekton-bucket         --resource=builtBaseImage=base-image         --resource=builtEntrypointImage=entrypoint-image         --resource=builtKubeconfigWriterImage=kubeconfigwriter-image         --resource=builtCredsInitImage=creds-init-image         --resource=builtGitInitImage=git-init-image         --resource=builtNopImage=nop-image         --resource=builtBashImage=bash-image         --resource=builtGsutilImage=gsutil-image         --resource=builtControllerImage=controller-image         --resource=builtWebhookImage=webhook-image         --resource=builtDigestExporterImage=digest-exporter-image         --resource=builtPullRequestInitImage=pull-request-init-image                 --resource=builtGcsFetcherImage=gcs-fetcher-image         pipeline-release

@afrittoli
Copy link
Member Author

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2019
@tekton-robot tekton-robot merged commit 6f4c38d into tektoncd:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants