Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a subfolder in the release bucket #1391

Merged
merged 1 commit into from
Oct 14, 2019

Conversation

afrittoli
Copy link
Member

The tekton release bucket shall host releases for all relevant
tekton projects. Pipeline should use its own dedicated subfolder.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Describe any user facing changes here, or delete this block.

Examples of user facing changes:
- API changes
- Bug fixes
- Any changes in behavior

@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Oct 8, 2019
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 8, 2019
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 8, 2019
@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 8, 2019
@bobcatfish bobcatfish added this to the Pipelines 0.8 🐱 milestone Oct 8, 2019
@bobcatfish
Copy link
Collaborator

Just in time @afrittoli !! 😆

@afrittoli can you also update our installation docs? https://github.com/tektoncd/pipeline/blob/master/docs/install.md#installing-tekton-pipelines-1

If we want to move the existing releases to this structure also i recommend we copy them (at least initially) so anyone trying to install based on the old location still can

@vdemeester
Copy link
Member

@afrittoli can you add "Closes #57" in the description to closes the issue 👼

@afrittoli
Copy link
Member Author

@afrittoli can you add "Closes #57" in the description to closes the issue 👼

uhm, that would point to pipeline #57

@vdemeester
Copy link
Member

dang… "Closes tektoncd/plumbing#57" then 😝

The tekton release bucket shall host releases for all relevant
tekton projects. Pipeline should use its own dedicated subfolder.

Closes tektoncd/plumbing#57
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2019
@afrittoli
Copy link
Member Author

Just in time @afrittoli !! 😆

@afrittoli can you also update our installation docs? https://github.com/tektoncd/pipeline/blob/master/docs/install.md#installing-tekton-pipelines-1

If we want to move the existing releases to this structure also i recommend we copy them (at least initially) so anyone trying to install based on the old location still can

Updated the docs, and created a copy of previous releases.

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2019
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@afrittoli
Copy link
Member Author

Can we cancel the hold now?

@vdemeester
Copy link
Member

indeed 😝
/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2019
@tekton-robot tekton-robot merged commit d7d52b6 into tektoncd:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants