Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs to GCS resource on required permissions #1235

Closed
bobcatfish opened this issue Aug 22, 2019 · 0 comments · Fixed by #1436
Closed

Add docs to GCS resource on required permissions #1235

bobcatfish opened this issue Aug 22, 2019 · 0 comments · Fixed by #1436
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@bobcatfish
Copy link
Collaborator

Expected Behavior

The docs for each PipelineResource should provide a good landing page including all the info a user need to use the Resource.

Actual Behavior

The GCS storage resource docs (https://github.com/tektoncd/pipeline/blob/master/docs/resources.md#gcs-storage-resource) say "To access GCS private buckets, service accounts are required with correct permissions." and link to docs on service accounts, but don't link to any docs on what permissions are required.

Additional Info

We should avoid writing new docs ourselves but should link to the correct docs as much as possible.
@bobcatfish bobcatfish added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Aug 22, 2019
chandanikumari added a commit to chandanikumari/pipeline that referenced this issue Oct 17, 2019
@chandanikumari
fix: Added URL for permission
2a7e728 
This pull request is in regards with tektoncd#1235
@chandanikumari chandanikumari mentioned this issue Oct 17, 2019
Merged
3 tasks
tekton-robot pushed a commit that referenced this issue Oct 17, 2019
@chandanikumari @tekton-robot
fix: Added URL for permission
08a8e8d 
This pull request is in regards with #1235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix : Added URL for permission chandanikumari/pipeline
1 participant
@bobcatfish