Correct pod watching in Taskrun controller

Should use `cache.FilteringResourceEventHandler` rather than `cache.ResourceEventHandlerFuncs`. The `pod` with incorrect owner will not go into the queue.
tektoncd · Sep 23, 2019 · 04dfa5b · 04dfa5b
1 parent cd5b973
commit 04dfa5b
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/pkg/reconciler/taskrun/controller.go b/pkg/reconciler/taskrun/controller.go
@@ -20,6 +20,7 @@ import (
 	"context"
 	"time"
 
+	"github.com/tektoncd/pipeline/pkg/apis/pipeline/v1alpha1"
 	pipelineclient "github.com/tektoncd/pipeline/pkg/client/injection/client"
 	clustertaskinformer "github.com/tektoncd/pipeline/pkg/client/injection/informers/pipeline/v1alpha1/clustertask"
 	resourceinformer "github.com/tektoncd/pipeline/pkg/client/injection/informers/pipeline/v1alpha1/pipelineresource"
@@ -84,10 +85,10 @@ func NewController(
 	})
 
 	c.tracker = tracker.New(impl.EnqueueKey, controller.GetTrackerLease(ctx))
-	podInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{
-		AddFunc:    impl.EnqueueControllerOf,
-		UpdateFunc: controller.PassNew(impl.EnqueueControllerOf),
-		DeleteFunc: impl.EnqueueControllerOf,
+
+	podInformer.Informer().AddEventHandler(cache.FilteringResourceEventHandler{
+		FilterFunc: controller.Filter(v1alpha1.SchemeGroupVersion.WithKind("TaskRun")),
+		Handler:    controller.HandleAll(impl.EnqueueControllerOf),
 	})
 
 	// FIXME(vdemeester) it was never set