This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Tooltip: implement with Radix UI
#2796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l the positioning ourselves The positioning is very complicated, and it was bugged.
Horizontal and vertical don't exist anymore
Radix renders the tooltip content 2 times, one is just for accessibility.
lowiebenoot
requested review from
lorgan3,
jelledc,
KristofColpaert,
driesd,
qubis741,
eniskraasniqi1,
BeirlaenAaron and
JorenSaeyTL
lorgan3
previously approved these changes
Oct 30, 2023
farazatarodi
previously approved these changes
Oct 30, 2023
JorenSaeyTL
previously approved these changes
Oct 30, 2023
KristofColpaert
previously approved these changes
Oct 30, 2023
lowiebenoot
dismissed stale reviews from KristofColpaert, JorenSaeyTL, farazatarodi, and lorgan3
via
a038c63
lorgan3
approved these changes
Oct 31, 2023
lowiebenoot
requested review from
farazatarodi,
JorenSaeyTL and
KristofColpaert
farazatarodi
approved these changes
Oct 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While trying to solve a bug in our tooltip positioning, I created another bug and realised that we would actually need to change and rewrite it completely in order to get it correct. Instead of implementing it ourself, we opted for using the tooltip from Radix UI. In the future we might use other Radix primitives as well for other components.
I still had to keep the hovering and active state inside our component (instead of letting radix handle it), because radix doesn't have the
tooltipHideOnClick.I removed the
horizontalandverticalposition, but it will still render to the opposite side in case there is not enough space on the side that you chose.There is also no animation anymore when hiding the tooltip, because radix just removes it from the dom immediately.
Breaking changes
Tooltip: removed thehorizontalandverticalposition