This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Added color prop to ProgressStep #2750
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qubis741
requested review from
a team,
pidera,
JordyDeGroeve,
gdegirmenci,
eniskraasniqi1 and
JorenSaeyTL
and removed request for
a team
eniskraasniqi1
previously approved these changes
Sep 7, 2023
JorenSaeyTL
approved these changes
Sep 7, 2023
farazatarodi
reviewed
Sep 7, 2023
| @@ -24,13 +27,17 @@ const ProgressStep: GenericComponent<ProgressStepProps> = ({ | |||
| meta, | |||
| active = false, | |||
| completed = false, | |||
| color, | |||
There was a problem hiding this comment.
Can't the default color be mint and use the color prop as the index for the theme instead of colorClassName?
There was a problem hiding this comment.
no, because if ProgressTracker is ruby, then ProgressStep by default is mint and thats not what we want
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[22.3.0] - 2023-09-07
Added
ProgressStep:colorpropNeeded in https://teamleader.atlassian.net/browse/FRAF-2386
Design
https://www.figma.com/file/U6nkw6FKrk92id8ZKOQDPR/Multiple-deal-pipelines?type=design&node-id=4118-134022&mode=design&t=OeCOZnHNiovtbaMB-0
Screenshot
Manual check
ui/src/components/progressTracker/progressTracker.stories.tsx