Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Fix select width issue on firefox #2735

Merged
merged 4 commits into from
Aug 22, 2023
Merged

Conversation

lorgan3
Copy link
Contributor

@lorgan3 lorgan3 commented Aug 22, 2023

Description

This fixes an issue that on firefox the select grows larger than allowed when a long option is selected

Testing setup in case you want to check this for yourself:
Select basic story:

export const basic: ComponentStory<typeof Select> = (args) => (
  <Flex>
    <Box flex={1}>
      <Select {...args} />
    </Box>
    <Box flex={1} />
  </Flex>
);

Screenshot before this PR

Screen.Recording.2023-08-22.at.09.10.36.mov

Screenshot after this PR

Screen.Recording.2023-08-22.at.09.10.57.mov

Breaking changes

N/a

Let flexbox handle the rest

This fixes an issue that on firefox the select grows larger than allowed when a long option is selected
@lorgan3 lorgan3 added the bug label Aug 22, 2023
@lorgan3 lorgan3 self-assigned this Aug 22, 2023
@lorgan3 lorgan3 marked this pull request as ready for review August 22, 2023 07:20
@lorgan3 lorgan3 requested review from BrechtBonte, a team, jelledc, KristofColpaert, stefaandevylder, eniskraasniqi1 and JorenSaeyTL and removed request for a team August 22, 2023 07:20
@KristofColpaert
Copy link
Contributor

KristofColpaert commented Aug 22, 2023

Looks great 👍

@lorgan3 lorgan3 merged commit 3d6578c into next-release Aug 22, 2023
10 checks passed
@lorgan3 lorgan3 deleted the fix-firefox-select-bug branch August 22, 2023 11:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants