This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
[FIX] - Use Ref instead of a constant #2715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eniskraasniqi1
changed the title
eniskraasniqi1
requested review from
farazatarodi and
lowiebenoot
as code owners
eniskraasniqi1
requested review from
a team,
jelledc,
lorgan3,
KristofColpaert,
qubis741 and
BeirlaenAaron
and removed request for
a team
lorgan3
approved these changes
Jul 13, 2023
qubis741
approved these changes
Jul 13, 2023
lowiebenoot
approved these changes
Jul 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverts two files (
WysiwygEditor.tsx&TabGroup.tsx) from this PR. It also fixes the tab group bug, where the scroll wasn't working as it should.As per my understanding, the reason why this happened:
Since ref is mutable, when referencing ref.current inside a function (in our case
checkForScrollPosition) it will likely generate a new reference of the function between re-renders. But if you use a constant instead, that won't happen.