This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
[FRONT-524] Upgrade storybook to version 7 #2714
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addon-postcss is deprecated
lowiebenoot
requested review from
jelledc,
lorgan3,
KristofColpaert,
driesd,
qubis741,
stefaandevylder,
eniskraasniqi1,
BeirlaenAaron and
JorenSaeyTL
July 13, 2023 08:17
Looking into the failing chromatic |
Storybook can't handle other extensions anymore
lorgan3
previously approved these changes
Jul 13, 2023
Did a quick smoke test, seems to work 👍 |
…ies are not included. Couldn't use an exclude pattern, because iternally storybook prepends the pattern with .storybook/ which breaks the exclude pattern.
Ah didn't think of that. |
eniskraasniqi1
approved these changes
Jul 14, 2023
qubis741
approved these changes
Jul 14, 2023
jelledc
approved these changes
Jul 14, 2023
KristofColpaert
approved these changes
Jul 14, 2023
lorgan3
approved these changes
Jul 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded storybook and addons to version 7.
There's still a warning about an addon that will probably be deprecated in the future, but couldn't get the changelog working without that plugin.