Skip to content

Update target SDK

Update target SDK #867

GitHub Actions / detekt succeeded May 18, 2024 in 0s

reviewdog [detekt] report

reported by reviewdog 🐶

Findings (0)
Filtered Findings (93)

telnyx_rtc/src/main/java/com/telnyx/webrtc/sdk/TelnyxClient.kt|42 col 7| Class TelnyxClient is too large. Consider splitting it into smaller pieces.
telnyx_rtc/src/main/java/com/telnyx/webrtc/sdk/TelnyxClient.kt|955 col 18| The function onGatewayStateReceived appears to be too complex (16). Defined complexity threshold for methods is set to '15'
telnyx_rtc/src/main/java/com/telnyx/webrtc/sdk/TelnyxClient.kt|989 col 21| Line detected, which is longer than the defined maximum line length in the code style.
telnyx_rtc/src/main/java/com/telnyx/webrtc/sdk/TelnyxClient.kt|1016 col 17| Line detected, which is longer than the defined maximum line length in the code style.
app/src/main/java/com/telnyx/webrtc/sdk/ui/MainViewModel.kt|52 col 21| The function saveUserData(userName: String, password: String, fcmToken: String?, callerIdName: String, callerIdNumber: String, isDev: Boolean) has too many parameters. The current threshold is set to 6.
app/src/main/java/com/telnyx/webrtc/sdk/utility/MyFirebaseMessagingService.kt|140 col 55| This empty block of code can be removed.
app/src/main/java/com/telnyx/webrtc/sdk/utility/MyFirebaseMessagingService.kt|157 col 2| The file /github/workspace/app/src/main/java/com/telnyx/webrtc/sdk/utility/MyFirebaseMessagingService.kt is not ending with a new line.
app/src/main/java/com/telnyx/webrtc/sdk/utility/MyFirebaseMessagingService.kt|47 col 47| This expression contains a magic number. Consider defining it to a well named constant.
app/src/main/java/com/telnyx/webrtc/sdk/utility/MyFirebaseMessagingService.kt|90 col 37| This expression contains a magic number. Consider defining it to a well named constant.
app/src/main/java/com/telnyx/webrtc/sdk/utility/MyFirebaseMessagingService.kt|90 col 43| This expression contains a magic number. Consider defining it to a well named constant.
app/src/main/java/com/telnyx/webrtc/sdk/utility/MyFirebaseMessagingService.kt|90 col 49| This expression contains a magic number. Consider defining it to a well named constant.
app/src/main/java/com/telnyx/webrtc/sdk/utility/MyFirebaseMessagingService.kt|90 col 55| This expression contains a magic number. Consider defining it to a well named constant.
app/src/main/java/com/telnyx/webrtc/sdk/utility/MyFirebaseMessagingService.kt|90 col 61| This expression contains a magic number. Consider defining it to a well named constant.
app/src/main/java/com/telnyx/webrtc/sdk/utility/MyFirebaseMessagingService.kt|140 col 17| Private function sendNotification is unused.
app/src/main/java/com/telnyx/webrtc/sdk/utility/MyFirebaseMessagingService.kt|140 col 34| Function parameter messageBody is unused.
app/src/main/java/com/telnyx/webrtc/sdk/utility/MyFirebaseMessagingService.kt|144 col 27| Private property TAG is unused.
telnyx_rtc/src/main/java/com/telnyx/webrtc/sdk/utilities/ConnectivityHelper.kt|34 col 18| The caught exception is too generic. Prefer catching specific exceptions to the case that is currently handled.
telnyx_rtc/src/main/java/com/telnyx/webrtc/sdk/utilities/ConnectivityHelper.kt|61 col 18| The caught exception is too generic. Prefer catching specific exceptions to the case that is currently handled.
telnyx_rtc/src/main/java/com/telnyx/webrtc/sdk/socket/TxSocket.kt|34 col 5| Constructor parameter names should match the pattern: [a-z][A-Za-z0-9]*
telnyx_rtc/src/main/java/com/telnyx/webrtc/sdk/socket/TxSocket.kt|80 col 29| This expression contains a magic number. Consider defining it to a well named constant.
telnyx_rtc/src/main/java/com/telnyx/webrtc/sdk/socket/TxSocket.kt|81 col 26| This expression contains a magic number. Consider defining it to a well named constant.
telnyx_rtc/src/main/java/com/telnyx/webrtc/sdk/socket/TxSocket.kt|82 col 27| This expression contains a magic number. Consider defining it to a well named constant.
telnyx_rtc/src/test/java/com/telnyx/webrtc/sdk/testhelpers/BaseTest.kt|7 col 16| An abstract class without a concrete member can be refactored to an interface.
telnyx_rtc/src/test/java/com/telnyx/webrtc/sdk/testhelpers/BaseTest.kt|7 col 1| The class BaseTest only contains utility functions. Consider defining it as an object.
telnyx_rtc/src/test/java/com/telnyx/webrtc/sdk/utilities/ConnectivityHelperTest.kt|58 col 13| Private property manager is unused.
telnyx_rtc/src/test/java/com/telnyx/webrtc/sdk/TelnyxClientTest.kt|110 col 13| Private property manager is unused.
telnyx_rtc/src/test/java/com/telnyx/webrtc/sdk/socket/TxSocketTest.kt|48 col 13| Private property resp is unused.
telnyx_rtc/src/main/java/com/telnyx/webrtc/sdk/TelnyxConfig.kt|33 col 2| Line detected, which is longer than the defined maximum line length in the code style.
telnyx_rtc/src/main/java/com/telnyx/webrtc/sdk/TelnyxConfig.kt|57 col 2| Line detected, which is longer than the defined maximum line length in the code style.
telnyx_rtc/src/main/java/com/telnyx/webrtc/sdk/verto/send/SendingMessageBody.kt|12 col 2| Line detected, which is longer than the defined maximum line length in the code style.
telnyx_rtc/src/main/java/com/telnyx/webrtc/sdk/peer/Peer.kt|23 col 2| Line detected, which is longer than the defined maximum line length in the code style.
telnyx_rtc/src/main/java/com/telnyx/webrtc/sdk/Call.kt|213 col 6| Line detected, which is longer than the defined maximum line length in the code style.
telnyx_rtc/src/main/java/com/telnyx/webrtc/sdk/Call.kt|229 col 6| Line detected, which is longer than the defined maximum line length in the code style.
telnyx_rtc/src/main/java/com/telnyx/webrtc/sdk/Call.kt|253 col 6| Line detected, which is longer than the defined maximum line length in the code style.
telnyx_rtc/src/main/java/com/telnyx/webrtc/sdk/model/AudioDevice.kt|12 col 2| Line detected, which is longer than the defined maximum line length in the code style.
telnyx_rtc/src/main/java/com/telnyx/webrtc/sdk/model/AudioDevice.kt|19 col 15| This expression contains a magic number. Consider defining it to a well named constant.
telnyx_rtc/src/main/java/com/telnyx/webrtc/sdk/model/AudioDevice.kt|21 col 17| This expression contains a magic number. Consider defining it to a well named constant.
telnyx_rtc/src/main/java/com/telnyx/webrtc/sdk/model/LogLevel.kt|11 col 2| Line detected, which is longer than the defined maximum line length in the code style.
telnyx_rtc/src/main/java/com/telnyx/webrtc/sdk/model/LogLevel.kt|27 col 10| This expression contains a magic number. Consider defining it to a well named constant.
telnyx_rtc/src/main/java/com/telnyx/webrtc/sdk/model/LogLevel.kt|28 col 11| This expression contains a magic number. Consider defining it to a well named constant.
telnyx_rtc/src/main/java/com/telnyx/webrtc/sdk/model/LogLevel.kt|29 col 13| This expression contains a magic number. Consider defining it to a well named constant.
telnyx_rtc/src/main/java/com/telnyx/webrtc/sdk/model/LogLevel.kt|30 col 11| This expression contains a magic number. Consider defining it to a well named constant.
telnyx_rtc/src/main/java/com/telnyx/webrtc/sdk/model/LogLevel.kt|31 col 10| This expression contains a magic number. Consider defining it to a well named constant.
telnyx_rtc/src/main/java/com/telnyx/webrtc/sdk/model/LogLevel.kt|32 col 11| This expression contains a magic number. Consider defining it to a well named constant.
telnyx_rtc/src/main/java/com/telnyx/webrtc/sdk/model/CauseCode.kt|14 col 2| Line detected, which is longer than the defined maximum line length in the code style.
telnyx_rtc/src/main/java/com/telnyx/webrtc/sdk/model/CauseCode.kt|15 col 2| Line detected, which is longer than the defined maximum line length in the code style.
telnyx_rtc/src/main/java/com/telnyx/webrtc/sdk/model/CauseCode.kt|16 col 2| Line detected, which is longer than the defined maximum line length in the code style.
telnyx_rtc/src/main/java/com/telnyx/webrtc/sdk/model/CauseCode.kt|17 col 2| Line detected, which is longer than the defined maximum line length in the code style.
telnyx_rtc/src/main/java/com/telnyx/webrtc/sdk/model/CauseCode.kt|20 col 15| This expression contains a magic number. Consider defining it to a well named constant.
telnyx_rtc/src/main/java/com/telnyx/webrtc/sdk/model/CauseCode.kt|21 col 21| This expression contains a magic number. Consider defining it to a well named constant.
telnyx_rtc/src/main/java/com/telnyx/webrtc/sdk/model/CauseCode.kt|22 col 21| This expression contains a magic number. Consider defining it to a well named constant.
telnyx_rtc/src/main/java/com/telnyx/webrtc/sdk/model/CauseCode.kt|23 col 23| This expression contains a magic number. Consider defining it to a well named constant.
telnyx_rtc/src/main/java/com/telnyx/webrtc/sdk/model/SocketError.kt|17 col 18| This expression contains a magic number. Consider defining it to a well named constant.
telnyx_rtc/src/main/java/com/telnyx/webrtc/sdk/model/SocketError.kt|18 col 23| This expression contains a magic number. Consider defining it to a well named constant.
app/src/androidTest/java/com/telnyx/webrtc/sdk/testhelpers/SystemUIDemoModeHelper.kt|10 col 2| Line detected, which is longer than the defined maximum line length in the code style.
app/src/androidTest/java/com/telnyx/webrtc/sdk/testhelpers/BaseTestInstrumentation.kt|7 col 16| An abstract class without a concrete member can be refactored to an interface.
app/src/androidTest/java/com/telnyx/webrtc/sdk/testhelpers/BaseTestInstrumentation.kt|7 col 1| The class BaseTestInstrumentation only contains utility functions. Consider defining it as an object.
app/src/androidTest/java/com/telnyx/webrtc/sdk/ui/MainActivityTest.kt|237 col 2| The file /github/workspace/app/src/androidTest/java/com/telnyx/webrtc/sdk/ui/MainActivityTest.kt is not ending with a new line.
app/src/androidTest/java/com/telnyx/webrtc/sdk/ui/MainActivityTest.kt|86 col 13| Line detected, which is longer than the defined maximum line length in the code style.
app/src/androidTest/java/com/telnyx/webrtc/sdk/ui/MainActivityTest.kt|88 col 13| Line detected, which is longer than the defined maximum line length in the code style.
app/src/androidTest/java/com/telnyx/webrtc/sdk/ui/MainActivityTest.kt|113 col 9| Line detected, which is longer than the defined maximum line length in the code style.
app/src/androidTest/java/com/telnyx/webrtc/sdk/ui/MainActivityTest.kt|122 col 4| Line detected, which is longer than the defined maximum line length in the code style.
app/src/androidTest/java/com/telnyx/webrtc/sdk/ui/MainActivityTest.kt|122 col 4| Line detected, which is longer than the defined maximum line length in the code style.
app/src/androidTest/java/com/telnyx/webrtc/sdk/ui/MainActivityTest.kt|161 col 13| Line detected, which is longer than the defined maximum line length in the code style.
app/src/androidTest/java/com/telnyx/webrtc/sdk/ui/MainActivityTest.kt|163 col 13| Line detected, which is longer than the defined maximum line length in the code style.
app/src/androidTest/java/com/telnyx/webrtc/sdk/ui/MainActivityTest.kt|174 col 5| Line detected, which is longer than the defined maximum line length in the code style.
app/src/androidTest/java/com/telnyx/webrtc/sdk/ui/MainActivityTest.kt|174 col 5| Line detected, which is longer than the defined maximum line length in the code style.
app/src/androidTest/java/com/telnyx/webrtc/sdk/ui/MainActivityTest.kt|206 col 13| Line detected, which is longer than the defined maximum line length in the code style.
app/src/androidTest/java/com/telnyx/webrtc/sdk/ui/MainActivityTest.kt|208 col 13| Line detected, which is longer than the defined maximum line length in the code style.
app/src/main/java/com/telnyx/webrtc/sdk/App.kt|21 col 2| The file /github/workspace/app/src/main/java/com/telnyx/webrtc/sdk/App.kt is not ending with a new line.
app/src/main/java/com/telnyx/webrtc/sdk/manager/UserManager.kt|79 col 2| The file /github/workspace/app/src/main/java/com/telnyx/webrtc/sdk/manager/UserManager.kt is not ending with a new line.
app/src/main/java/com/telnyx/webrtc/sdk/di/AppModule.kt|32 col 2| The file /github/workspace/app/src/main/java/com/telnyx/webrtc/sdk/di/AppModule.kt is not ending with a new line.
app/src/main/java/com/telnyx/webrtc/sdk/ui/SplashScreenActivity.kt|17 col 2| The file /github/workspace/app/src/main/java/com/telnyx/webrtc/sdk/ui/SplashScreenActivity.kt is not ending with a new line.
app/src/main/java/com/telnyx/webrtc/sdk/ui/CallInstanceFragment.kt|209 col 2| The file /github/workspace/app/src/main/java/com/telnyx/webrtc/sdk/ui/CallInstanceFragment.kt is not ending with a new line.
app/src/main/java/com/telnyx/webrtc/sdk/ui/CallInstanceFragment.kt|38 col 81| This expression contains a magic number. Consider defining it to a well named constant.
app/src/main/java/com/telnyx/webrtc/sdk/ui/CallInstanceFragment.kt|173 col 54| This expression contains a magic number. Consider defining it to a well named constant.
app/src/main/java/com/telnyx/webrtc/sdk/ui/CallInstanceFragment.kt|176 col 54| This expression contains a magic number. Consider defining it to a well named constant.
app/src/main/java/com/telnyx/webrtc/sdk/ui/CallInstanceFragment.kt|179 col 54| This expression contains a magic number. Consider defining it to a well named constant.
app/src/main/java/com/telnyx/webrtc/sdk/ui/CallInstanceFragment.kt|181 col 13| This expression contains a magic number. Consider defining it to a well named constant.
app/src/main/java/com/telnyx/webrtc/sdk/ui/CallInstanceFragment.kt|182 col 54| This expression contains a magic number. Consider defining it to a well named constant.
app/src/main/java/com/telnyx/webrtc/sdk/ui/CallInstanceFragment.kt|184 col 13| This expression contains a magic number. Consider defining it to a well named constant.
app/src/main/java/com/telnyx/webrtc/sdk/ui/CallInstanceFragment.kt|185 col 54| This expression contains a magic number. Consider defining it to a well named constant.
app/src/main/java/com/telnyx/webrtc/sdk/ui/CallInstanceFragment.kt|187 col 13| This expression contains a magic number. Consider defining it to a well named constant.
app/src/main/java/com/telnyx/webrtc/sdk/ui/CallInstanceFragment.kt|188 col 54| This expression contains a magic number. Consider defining it to a well named constant.
app/src/main/java/com/telnyx/webrtc/sdk/ui/CallInstanceFragment.kt|190 col 13| This expression contains a magic number. Consider defining it to a well named constant.
app/src/main/java/com/telnyx/webrtc/sdk/ui/CallInstanceFragment.kt|191 col 54| This expression contains a magic number. Consider defining it to a well named constant.
app/src/main/java/com/telnyx/webrtc/sdk/ui/CallInstanceFragment.kt|193 col 13| This expression contains a magic number. Consider defining it to a well named constant.
app/src/main/java/com/telnyx/webrtc/sdk/ui/CallInstanceFragment.kt|194 col 54| This expression contains a magic number. Consider defining it to a well named constant.
app/src/main/java/com/telnyx/webrtc/sdk/ui/CallInstanceFragment.kt|196 col 13| This expression contains a magic number. Consider defining it to a well named constant.
app/src/main/java/com/telnyx/webrtc/sdk/ui/CallInstanceFragment.kt|197 col 54| This expression contains a magic number. Consider defining it to a well named constant.
app/src/main/java/com/telnyx/webrtc/sdk/ui/CallInstanceFragment.kt|199 col 13| This expression contains a magic number. Consider defining it to a well named constant.
app/src/main/java/com/telnyx/webrtc/sdk/ui/CallInstanceFragment.kt|200 col 54| This expression contains a magic number. Consider defining it to a well named constant.
app/src/main/java/com/telnyx/webrtc/sdk/ui/MainActivity.kt|544 col 30| This expression contains a magic number. Consider defining it to a well named constant.