Skip to content

Commit

Permalink
Remove Unused Dep (Volley)
Browse files Browse the repository at this point in the history
  • Loading branch information
isaacakakpo1 committed May 17, 2024
1 parent a378878 commit 24e4316
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 12 deletions.
7 changes: 2 additions & 5 deletions app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@ def localProperties = new Properties()
localProperties.load(new FileInputStream(rootProject.file("local.properties")))

android {
compileSdkVersion 33
compileSdkVersion 34
buildToolsVersion "30.0.3"

defaultConfig {
applicationId "com.telnyx.webrtc.sdk"
minSdkVersion 23
targetSdkVersion 33
targetSdkVersion 34
versionCode 1
versionName "1.0"

Expand Down Expand Up @@ -120,9 +120,6 @@ dependencies {
implementation deps.ktor.gson
implementation deps.ktor.websockets

// Volley
implementation deps.volley

// Firebase
implementation platform(deps.firebasebom)
implementation deps.firebase_analytics
Expand Down
5 changes: 5 additions & 0 deletions app/src/main/java/com/telnyx/webrtc/sdk/ui/MainActivity.kt
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,11 @@ class MainActivity : AppCompatActivity() {
Timber.i("Loading...")
}

override fun onChanged(value: SocketResponse<ReceivedMessageBody>) {
super.onChanged(value)
// Do Nothing
}

override fun onError(message: String?) {
Timber.e("onError: %s", message)
Toast.makeText(
Expand Down
8 changes: 3 additions & 5 deletions telnyx_rtc/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ dependencies {
implementation deps.ktor.gson
implementation deps.ktor.websockets
implementation deps.ktor.okhttp
implementation 'androidx.lifecycle:lifecycle-process:2.8.0'
implementation 'androidx.lifecycle:lifecycle-process:2.7.0'
testImplementation deps.ktor.client_test

implementation 'org.jetbrains.kotlin:kotlin-android-extensions-runtime:1.7.10'
Expand All @@ -207,8 +207,6 @@ dependencies {
//BugSnag:
implementation "com.bugsnag:bugsnag-android:5.+"

// Volley
implementation deps.volley

// Firebase
implementation platform(deps.firebasebom)
Expand Down Expand Up @@ -266,7 +264,7 @@ dependencies {
androidTestImplementation 'androidx.test.ext:truth:1.4.0'
androidTestImplementation 'androidx.test.ext:junit:1.1.3'
androidTestImplementation 'androidx.work:work-testing:2.7.1'
androidTestImplementation "io.mockk:mockk-android:1.12.5"
androidTestImplementation "io.mockk:mockk-androitd:1.12.5"
debugImplementation 'androidx.fragment:fragment-testing:1.5.2'
debugImplementation 'androidx.test:core-ktx:1.4.0'

Expand All @@ -276,6 +274,6 @@ dependencies {
androidTestImplementation 'androidx.test.ext:junit:1.1.3'
androidTestImplementation 'androidx.test.espresso:espresso-core:3.4.0'

def lifecycle_version = "2.8.0"
def lifecycle_version = "2.7.0"
implementation "androidx.lifecycle:lifecycle-viewmodel-ktx:$lifecycle_version"
}
2 changes: 0 additions & 2 deletions versions.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ versions.ktor = "1.5.3"
versions.timber = "4.5.1"
versions.dexter = "6.2.2"
versions.googleservices = "4.3.8"
versions.volley = "1.1.1"
versions.firebasebom = "28.2.1"
versions.hilt = "2.43.2"
versions.bugsnag = "7.+"
Expand All @@ -37,7 +36,6 @@ deps.androidx_fragment = "androidx.fragment:fragment-ktx:$versions.androidx_frag
deps.appcompat = "androidx.appcompat:appcompat:$versions.androidx_appcompat"
deps.material = "com.google.android.material:material:$versions.material"
deps.constraint_layout = "androidx.constraintlayout:constraintlayout:$versions.androidx_constraint_layout"
deps.volley = "com.android.volley:volley:$versions.volley"
deps.webrtc = "org.webrtc:google-webrtc:$versions.webrtc"
deps.gson = "com.google.code.gson:gson:$versions.gson"
deps.websocket = "org.java-websocket:Java-WebSocket:$versions.websocket"
Expand Down

0 comments on commit 24e4316

Please sign in to comment.