Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require key for produce onto compacted topic #780

Merged
merged 3 commits into from
Aug 13, 2021
Merged

Require key for produce onto compacted topic #780

merged 3 commits into from
Aug 13, 2021

Conversation

timtebeek
Copy link
Contributor

@tchiotludo
Copy link
Owner

Just a concern here.
If the ACL doesn't allow you to read the config, it will failed with exception.
On this case, I think it's better to remove the check

@timtebeek
Copy link
Contributor Author

Not sure if I read your comments correctly, but I've added a try-catch-log block in case there's any ExecutionException while checking to see if topic is compacted. If you had intended any other/further changes please let me know.

And thanks for the other couple of merges as well. Nice to see these added! :)

@tchiotludo tchiotludo merged commit c499155 into tchiotludo:dev Aug 13, 2021
@timtebeek timtebeek deleted the require_key_for_produce_onto_compacted_topic branch August 13, 2021 07:04
tchiotludo pushed a commit that referenced this pull request Oct 24, 2021
@tchiotludo
fix(topic data): require key for produce onto compacted topic (#780)
9894d0b 
close #133
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception when producing to compacted topic without a key
2 participants
@timtebeek @tchiotludo