Allows List or String in topics-filter-regex #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync dev branch
…nd groups-filter-regex
…nd groups-filter-regex
|
Seems to be perfect, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #656
I haven't been able to test with security enabled but I tested with default group using both List and String yaml configuration, and it works as intended.
All thanks to Micronaut that maps a String property into a List seamlessly (creating a list of one).
See attached test.
I didn't test connects-filter-regx or groups-filter-regex since the code is 100% reused.
@tchiotludo
Could you test with security enabled to confirm that the generated JWT looks ok (compared to #656) ?
If not possible, I'll find some time next week to test on a real cluster.