Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added validations for the cluster parameter in API using exceptions #1104

Merged

Conversation

rdrck47
Copy link
Contributor

@rdrck47 rdrck47 commented May 26, 2022

Hello! Here is an alternative solution that targets issue #1094.

  • Adds validations in the API for checking that the provided cluster-name parameter is configured using exceptions.

Let me know if you got any questions or suggestions to improve my solution.

@tchiotludo tchiotludo force-pushed the add-api-cluster-validation-with-exceptions branch from 086b638 to 282c125 Compare May 26, 2022 19:58
@tchiotludo tchiotludo merged commit 676d89a into tchiotludo:dev May 26, 2022
@tchiotludo
Copy link
Owner

perfect, just inverted the logic and use a custom exception!

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants