Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show size in bytes in the /topic page #616

Closed
singsuyash opened this issue Mar 5, 2021 · 17 comments · Fixed by #709
Closed

Show size in bytes in the /topic page #616

singsuyash opened this issue Mar 5, 2021 · 17 comments · Fixed by #709
Labels
enhancement New feature or request good first issue Good for newcomers ui Need an ui update

Comments

@singsuyash
Copy link

Is there a configuration i can use to show the topic size in bytes in the /topic page.
The size column stays at a unit until the value for that unit changes which does not give the right picture.

Example:
Entity: Apple
Entity Size: 500 KB
Size displayed for 2000 Apples = 1GB
Size displayed for 3999 Apples = 1GB
Size displayed for 4000 Apples = 2GB

@tchiotludo
Copy link
Owner

Hi,

Can you send me a screenshot ? I'm not sure to understand

@singsuyash
Copy link
Author

image
image
image
image
image
image

As you can see, if the sizes are not displayed in Bytes, it gives a wrong impression of count vs size.

@tchiotludo
Copy link
Owner

You want to less round the size ?
For example, display 1.235G ?

@singsuyash
Copy link
Author

OR always show the size in Bytes, whichever gives me correct size for the message counts.

@tchiotludo
Copy link
Owner

I will prefer rounded value, bytes is unreadable

@tchiotludo tchiotludo added enhancement New feature or request ui Need an ui update labels Apr 14, 2021
@tchiotludo tchiotludo added the good first issue Good for newcomers label Apr 14, 2021
@ThiagoTeodoro
Copy link
Contributor

ThiagoTeodoro commented May 14, 2021

Hi Everyone!

I would love work on this...

@tchiotludo , can you confirm if is just make a function to show in GB in this point of the code?

size: showBytes(topic.logDirSize, 0),

@tchiotludo
Copy link
Owner

hi @ThiagoTeodoro, yes, this is a good function to update 👍

@ThiagoTeodoro
Copy link
Contributor

ThiagoTeodoro commented May 14, 2021

Nice @tchiotludo, i will work on this solution in the next's days.
Would be nice if you have any guide i can follow to put all envoriment up im my local machine to se the page @singsuyash put on the comment above.
If you don`t have any guide no problem, i will check the dependencies anyway.

You can assign to me btw.

@tchiotludo
Copy link
Owner

@ThiagoTeodoro look here : https://github.com/tchiotludo/akhq#setup-local-dev-environment-on-windows
There is a tutorial that works I think, you can tune this one to use a docker image for kafka (like I do)

@ThiagoTeodoro
Copy link
Contributor

ThiagoTeodoro commented May 17, 2021

@tchiotludo could pls pass the MICRONAUT_CONFIG_FILES: '/app/application.dev.yml file?
I can't find in the repository.

I try to comment this line in the docker-compose-dev.yml, to force ready for local in resource path but don't work.
So i think its better you pass me the right file, because when i try to configure, its a little confuse to me point all the clusters values.

This is my last try error but here i think its problem of my attempt configuration :

image

Anyway if you can send me the right file i will loved because will save a lot of my time.

@tchiotludo
Copy link
Owner

here is a minimal file, with only a kafka server :

akhq:
  connections:
    local:
      properties:
        bootstrap.servers: "localhost:9092"

and a more complete with registry and connect :

akhq:
  connections:
    local:
      properties:
        bootstrap.servers: "localhost:9092"
      schema-registry:
        url: "http://localhost:8085"
      connect:
        - name: connect
          url: "http://localhost:8083"

@ThiagoTeodoro
Copy link
Contributor

ThiagoTeodoro commented May 18, 2021

Sorry disturb you again @tchiotludo , but i try to make docker-compose -f docker-compose-dev.yml up with the minimal file you said

application.dev.yml

akhq:
  connections:
    local:
      properties:
        bootstrap.servers: "localhost:9092"

And not work.... i have this main error in all my try :

image

I know its not necessary run the environment to make this improvement but, i want to understand more of this project to contribute more.

If you have another channel to communicate and help me with this initial configuration, because from my view its all good, don't see what its wrong.

@tchiotludo
Copy link
Owner

I've just updated the docker-compose-dev.yml to work on most of the case with reload of java server & react, just reach the http://localhost:3000 normally

@ThiagoTeodoro
Copy link
Contributor

I've just updated the docker-compose-dev.yml to work on most of the case with reload of java server & react, just reach the http://localhost:3000 normally

@tchiotludo Thanks! I will update my fork tomorrow and try to continue with my contribution.

@ThiagoTeodoro
Copy link
Contributor

ThiagoTeodoro commented May 19, 2021

Hello @tchiotludo i resolved this issue in this PR: #709

If you can please look the resolution =D i will loved listen your feedback.

This is a image with the implementation in my machine.

image

ThiagoTeodoro added a commit to sidilabs/akhq that referenced this issue May 21, 2021
Implements a function to show bytes size with a round way.
With this commit now its possible se values likce 1.2567 GB

Resolve tchiotludo#616
@ThiagoTeodoro
Copy link
Contributor

ThiagoTeodoro commented May 21, 2021

@tchiotludo I'm make a update on my PR to use the SiDi Labs organization account fork. So now you can check the PR: #709

@ThiagoTeodoro
Copy link
Contributor

@tchiotludo wait your approval, i make the changes you request in the PR : #709

tchiotludo pushed a commit that referenced this issue Jun 10, 2021
Implements a function to show bytes size with a round way.
With this commit now its possible se values likce 1.256 GB

close #616
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers ui Need an ui update
Projects
Status: Done
3 participants