277 create all endpoints for assingment #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TejasNair9977
requested changes
Sep 3, 2023
TejasNair9977
requested changes
Sep 7, 2023
controller/assignment.js
Outdated
| @@ -0,0 +1,53 @@ | |||
| import { | |||
| createAssignment, deleteAssignmentById, assignmentList, updateAssignmentById, | |||
| } from "#services/assignment "; | |||
There was a problem hiding this comment.
just one tiny change, this is causing test cases to fail, please remove this space. and use setup.js, otherwise random errors like this would happen.
Suggested change
| } from "#services/assignment "; | |
| } from "#services/assignment"; |
|
nvm i fixed it |
TejasNair9977
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
added endpoints for assingment
Fixes
#277
Checklist
Notes
(PS → Make Sure Pull request title is meaningful.)