Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Added CRUD in Tutorial Model #217 #233

Merged
merged 1 commit into from
Aug 26, 2023

Conversation

Aryanzs
Copy link
Contributor

@Aryanzs Aryanzs commented Aug 22, 2023

Description

Added CRUD operations to the tutorial model

Fixes

Fixes #207

Checklist

  • Code follows project's style guidelines.
  • Changes are documented appropriately.


// Delete tutorials based on a given filter
async function remove(filter) {
const deleteResult = await Tutorial.deleteMany(filter).exec();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there exec() function used here? I don't think we need it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking of it as confirming your request to delete items from the database. Once you press "Go" (by using .exec()). Should i change it and make another commit or let it be?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be fine

Copy link
Member

@TejasNair9977 TejasNair9977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TejasNair9977 TejasNair9977 merged commit 2c6d7f8 into tcet-opensource:development Aug 26, 2023
1 check failed
@Aryanzs Aryanzs deleted the development branch September 1, 2023 18:07
@Aryanzs Aryanzs restored the development branch September 1, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants