Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

112 refactor curd faculty model #155

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
137 changes: 50 additions & 87 deletions models/faculty.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use virtual attributes as used in models/course.js

Original file line number Diff line number Diff line change
@@ -1,94 +1,57 @@
const { connector } = require("./databaseUtil");

const facultySchema = {
name: {
type: String,
required: true,
},
department: {
type: connector.Schema.Types.ObjectId,
ref: "Department",
required: true,
},
empType: {
type: String,
required: true,
},
emdUID: {
type: String,
required: true,
},
preferredSubjects: {
type: [{ type: connector.Schema.Types.ObjectId, ref: "Subject" }],
required: true,
},
profileLink: {
type: String,
required: true,
},
designation: {
type: [String],
required: true,
},
natureOfAssociation: {
type: String,
required: true,
},
uniApprovalStatus: {
type: String,
required: true,
},
qualifications: {
type: [String],
required: true,
},
totalExperience: {
type: String,
required: true,
},
additionalResponsibilities: {
type: String,
required: true,
},
achievements: {
type: [String],
required: true,
},
areaOfSpecialization: {
type: [String],
required: true,
},
papersPublishedPG: {
type: Number,
required: true,
},
papersPublishedUG: {
type: Number,
required: true,
},
email: {
type: String,
required: true,
unique: true,
},
phoneNumber: {
type: String,
required: true,
},
office: {
type: String,
required: true,
},
isTenured: {
type: Boolean,
default: false,
},
joinedDate: {
type: Date,
default: Date.now,
},
ERPID: { type: String, required: true },
dateOfJoining: { type: Date, required: true, default: Date.now },
dateOfLeaving: { type: Date, required: false },
profileLink: { type: String, required: true },
qualifications: { type: [String], required: true },
totalExperience: { type: Number, required: true },
achievements: { type: [String], required: true },
areaOfSpecialization: { type: [String], required: true },
papersPublishedPG: { type: Number, required: true },
papersPublishedUG: { type: Number, required: true },
department: { type: connector.Schema.Types.ObjectId, ref: "Department", required: true },
preferredSubjects: [{ type: connector.Schema.Types.ObjectId, ref: "Course", required: true }],
designation: { type: [String], enum: ["HOD", "Assistant Professor", "Associate Professor", "Activity Head"], required: true },
natureOfAssociation: { type: String, enum: ["Regular", "Contract", "Adjunct"], required: true },
additionalResponsibilities: { type: String, required: true },
};

facultySchema.virtual('tcetexperience').get(function() {
const currentDate = new Date();
const joiningYear = this.dateOfJoining.getFullYear();
const leavingYear = this.dateOfLeaving ?
this.dateOfLeaving.getFullYear :
currentDate.getFullYear;
return leavingYear - joiningYear;
});

const Faculty = connector.model("Faculty", facultySchema);

module.exports = Faculty;
// CRUD Operations

async function remove(filter) {
const del = await Faculty.findOneAndDelete(filter);
return del;
}

async function create(facultyData) {
const faculty = new Faculty(facultyData);
const facultyDoc = await faculty.save();
return facultyDoc;
}

async function read(filter, limit = 1) {
const facultyread = await Faculty.find(filter).limit(limit);
return facultyread;
}

async function update(filter, updateObject) {
const faculty = await Faculty.findOneAndUpdate(filter, updateObject, { new: true });
return faculty;
}

export default {
create, read, update, remove,
};
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"test": "NODE_OPTIONS=--experimental-vm-modules npx jest",
"test:watch": "NODE_OPTIONS=--experimental-vm-modules npx jest --watch",
"test:openHandels": "NODE_OPTIONS=--experimental-vm-modules npx jest --detectOpenHandles",
"eslint": "eslint '**/*.js'"
"eslint": "eslint ."
},
"dependencies": {
"apidoc": "^1.0.3",
Expand Down
Loading